Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in pprof registered urls and in READMEs #1427

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix typo in pprof registered urls and in READMEs #1427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
509e47e
Fix typo in pprof registered urls and in READMEs
Jan 29, 2025
a0092f3
Merge branch 'develop' into bugfix/fix-pprof-register-urls-and-typos
patrykw-splunk Feb 5, 2025
f29f58a
Merge branch 'develop' into bugfix/fix-pprof-register-urls-and-typos
patrykw-splunk Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/debug/register.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func RegisterEndpoint(register func(string, http.Handler) error, options *Option
}
}
if options.Symbol {
err := register("/debug/pprof/symobol", http.HandlerFunc(pprof.Symbol))
err := register("/debug/pprof/symbol", http.HandlerFunc(pprof.Symbol))
if err != nil {
return err
}
Expand Down
4 changes: 2 additions & 2 deletions test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ resources are then created in that new namespace:
1. Operator/Deployment

The tests are then run within the scope/context of the TestEnv object. Resources used by the tests are scoped to the
TestEnv object (ie Kubernetes namespace). When the tests are completed, the TestEnv object is destroyed and the
TestEnv object (i.e Kubernetes namespace). When the tests are completed, the TestEnv object is destroyed and the
resources within are deleted.

### Deployment
Expand Down Expand Up @@ -98,7 +98,7 @@ it is best to copy an existing test spec file in that suite and modified it.

### Add a new test suite

1. If you are adding a new test suite (ie you want to run the test in a separate TestEnv or k8s namespace), it is best to copy the test/example folder entirely and modify it
1. If you are adding a new test suite (i.e you want to run the test in a separate TestEnv or k8s namespace), it is best to copy the test/example folder entirely and modify it

## Notes

Expand Down
4 changes: 2 additions & 2 deletions test/deploy-eks-cluster.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
#!/bin/bash

if [[ -z "${EKS_VPC_PUBLIC_SUBNET_STRING}" ]]; then
echo "EKS PUBLIC SUBNET STRING not set. Chaning to env.sh value"
echo "EKS PUBLIC SUBNET STRING not set. Changing to env.sh value"
export EKS_VPC_PUBLIC_SUBNET_STRING="${VPC_PUBLIC_SUBNET_STRING}"
fi

if [[ -z "${EKS_VPC_PRIVATE_SUBNET_STRING}" ]]; then
echo "EKS PRIVATE SUBNET STRING not set. Chaning to env.sh value"
echo "EKS PRIVATE SUBNET STRING not set. Changing to env.sh value"
export EKS_VPC_PRIVATE_SUBNET_STRING="${VPC_PRIVATE_SUBNET_STRING}"
fi

Expand Down
Loading