Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-fetch instanceType if not provided #202

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Re-fetch instanceType if not provided #202

merged 2 commits into from
Dec 8, 2022

Conversation

ashah-splunk
Copy link
Contributor

@ashah-splunk ashah-splunk commented Nov 30, 2022 •
edited by fantavlik
Loading

  • re-fetch instancetype and version if not set within Service instance to avoid NPE
  • also provide local IP as alternative to localhost, addressing issue with certain local workflows

@ashah-splunk
code fix
ce4631b 
re-fetch version and InstanceType if null
@ashah-splunk ashah-splunk changed the base branch from master to develop November 30, 2022 11:43
fantavlik
fantavlik approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me, thanks for the quick turnaround. Let's confirm with the user reporting this issue before merging but approved from my standpoint.

@ashah-splunk
Update HttpService.java
c4fc1d9 
added check for Host IP address.
@fantavlik fantavlik changed the title Itsi app fix Re-fetch instanceType if not provided Dec 5, 2022
@fantavlik
Copy link
Contributor

Just updated the PR description but other than that the changes look good - feel free to merge when we have validation

@ashah-splunk ashah-splunk merged commit e485ba4 into develop Dec 8, 2022
@ashah-splunk ashah-splunk mentioned this pull request Dec 8, 2022
Merged
@jnturton jnturton mentioned this pull request Dec 12, 2022
Merged
@exceptionfactory exceptionfactory mentioned this pull request Feb 8, 2023
Closed
12 tasks
@ashah-splunk ashah-splunk deleted the itsi-app-fix branch April 20, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantavlik fantavlik fantavlik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashah-splunk @fantavlik