Gradle: Configure compiler options via build-logic #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beatbrot
force-pushed
the
compile-options-to-build-logic
branch
from
1436d62 to
e7bf588
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2026 +/- ##
============================================
+ Coverage 80.44% 81.80% +1.35%
- Complexity 4337 4614 +277
============================================
Files 441 448 +7
Lines 13534 14463 +929
Branches 1707 1830 +123
============================================
+ Hits 10888 11832 +944
+ Misses 2008 1954 -54
- Partials 638 677 +39 ☔ View full report in Codecov by Sentry. |
beatbrot
force-pushed
the
compile-options-to-build-logic
branch
from
e7bf588 to
c98b28b
Compare
Moving these "uninteresting" options to build-logic cleans up the build.gradle file and makes it more readable
AndreasTu
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
LGTM, thanks @beatbrot for the change.
@leonard84 can you also have a look?
|
Thank you very much for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves some of the "uninteresting" options to build-logic to clean up
<projectname>.gradlefiles.The basic idea of this PR is that much of the tedious configuration shall happen in the spockframework.base plugin.
All subprojects apply that plugin and profit from the abstraction.
"Interesting stuff" like declaration of dependencies shall still happen in
<projectname>.gradlefiles.I'd like to expand this idea , but I want to keep the PRs small and start with the most simple stuff first.