Only include vendored assets in the gem #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of the github workflow in a432faf bundler is run as part of making the gem and this adds bundled code in vendor/bundle. With the "vendor/**/*" spec in the gemspec file this code also gets included in the gem by accident.
|
Thank you for catching that. I'll release a new version of 7.1.2(.1) now. |
spohlenz
pushed a commit
that referenced
this pull request
Jun 20, 2024
With the introduction of the github workflow in a432faf bundler is run as part of making the gem and this adds bundled code in vendor/bundle. With the "vendor/**/*" spec in the gemspec file this code also gets included in the gem by accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of the github workflow in
a432faf bundler is run as part of making the gem and this adds bundled code in vendor/bundle.
With the "vendor/**/*" spec in the gemspec file this code also gets included in the gem by accident.