Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor of
Reflux.all
in #84 paved the way to implement the various join strategies as discussed by @bripkens and @spoike in #28 and #29. This pull request adds the following methods to theListenerMethods
:listener.joinLeading
listener.joinTrailing
listener.joinConcat
listener.joinStrict
...which corresponds to the four strategies outlined in previous discussions. Here's the new readme example:
I also expose them as static methods on the
Reflux
object, which automatically sets up the store and creates the join with triggerAsync as callback. As shown in the readme, the store in the example could then be created like this:The old
Reflux.all
method now corresponds toReflux.joinTrailing
. I've keptall
as an alias for backwards compatibility.I created a new test file for the join functionality, but kept the old one (
composedListenable.spec.js
) around as it also tests some composite stuff.