Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Starlight #98

Open
wants to merge 1 commit into
base: 1.16.x/dev
Choose a base branch
from
Open

Merge Starlight #98

wants to merge 1 commit into from

Conversation

Pannoniae
Copy link
Collaborator

We can merge Starlight if it's stable enough. Needs further testing.

@spoorn
Copy link
Owner

spoorn commented Jul 21, 2021

Starlight is already available for Forge though, it's just not on CurseForge. If we merge in Starlight, it should be under the Starlight owner's wish as we'll have to keep maintaining it for any bugs or issues. Why doesn't Starlight publish to CurseForge themselves?

@spoorn
Copy link
Owner

spoorn commented Jul 21, 2021

If we merge in Starlight and it splits development with the original Starlight, then the 2 will become incompatible

@Pannoniae
Copy link
Collaborator Author

Well Phosphor and Starlight obviously can't be run together so I've no idea what to do with this tbh.

@Pannoniae
Copy link
Collaborator Author

Or maybe a config option to switch between the two? It's possible with a custom mixin connector which decides which mixins to apply.

@spoorn
Copy link
Owner

spoorn commented Jul 22, 2021

I meant Starlight will keep updating, so if we merge it into here we'd have to maintain it. And then Sodium won't be compatible with Starlight if it ever gets added to Curseforge itself or if players add it manually - so I don't think we should merge Starlight into the release branch. If anything, it should stay in a separate branch

@Pannoniae
Copy link
Collaborator Author

So separate branch and separate releases on CurseForge?

@Pannoniae
Copy link
Collaborator Author

Hm, @spoorn alternate idea. How about detecting if Starlight is installed, and if yes, disabling Phosphor inside the mod? That way we won't have to include it ourselves.

@spoorn
Copy link
Owner

spoorn commented Jul 25, 2021

Do you mean disabling Starlight in the mod? Starlight features in Sodium is nice, but I don't have the time to maintain it :P

Also, the Starlight author seems to be purposely not releasing on CurseForge while they continue development (PaperMC/Starlight#21, PaperMC/Starlight#65), so I don't want to release it on CurseForge without their permission.

If they don't want Starlight on CurseForge, we can still have a starlight branch on github

@Pannoniae
Copy link
Collaborator Author

No, I didn't mean that. The idea is not merging this, and if Starlight is loaded (from the outside) disable Phosphor-related features in here. That way it should be compatible. Or is this a stupid idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants