Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Ganonhunt goal #1033

Merged
merged 7 commits into from
Feb 18, 2023
Merged

New Ganonhunt goal #1033

merged 7 commits into from
Feb 18, 2023

Conversation

tcprescott
Copy link
Collaborator

@tcprescott tcprescott commented Feb 16, 2023

Adds a new goal called "Ganonhunt". There are some things that I think we may still need to do regarding this PR, but I wanted to give you at least a first look at it. This will not currently work with Entrance Randomizer, and as a result it has been explicitly disabled. The frontend will force entrance shuffle off if the new goal is chosen, and if entrances are turned on while the new goal is chosen, it'll set the goal to Fast Ganon.

Rules:

  1. Pyramid is pre-opened.
  2. Agahnim 2 is not required
  3. Crystals are not required to defeat Ganon. Ganon vulnerability is strictly 40 Triforce Pieces.
  4. Crystals are still required for GT entry. GT fill rules are the same as the other Ganon goals.

Remaining (potential) tasks:

  • Get i18n from the community. Right now there's just placeholder English in place for the goal name and description.
  • Unit tests: Are unit tests needed for this?
  • Bug testing
  • Potentially update ER to also support this goal.
  • Right now it places 60 pieces, and 40 are required to engage Ganon. This may require further tuning discussion.

@tcprescott tcprescott changed the title New Triforce Pieces + Defeat Ganon goal New Triforce Pieces + Fast Ganon goal Feb 16, 2023
@tcprescott tcprescott changed the title New Triforce Pieces + Fast Ganon goal New Ganonhunt goal Feb 17, 2023
Copy link
Owner

@sporchia sporchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me, I figured we could update the ganon settings in Rom.php to match what is available in base rom

app/Rom.php Outdated Show resolved Hide resolved
tcprescott and others added 2 commits February 18, 2023 08:54
Co-authored-by: Salvatore <print@blindchaos.net>
@tcprescott tcprescott merged commit a50f182 into sporchia:v31.1 Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants