Detail Screen Style Alignment + Revisit Generated Seed Button + Permalink Always On #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DoctorBlue
commented
Jun 6, 2021
•
DoctorBlue
commented
- The post-generation Save ROM screen styles updated to match the permalink ROM Info screen
- Primarily accomplished by copying CSS/HTML from one to the other, and removing duplicate / unnecessary styles
- Before:
- After:
- Compare to the currently-live version of the permalink screen:
- Only difference stems from post-generation screen having buttons in the header
- Always show the permalink on the ROM Info screen, even when visiting via permalink
- Didn't get a strong response in chat as to why we're doing this
- Wanted the screens to be equivalent as much as possible
- If you generated a game, then click Change Settings: New button for returning to generated seed
- Just a simple boolean hack for now
- Can be expanded to shoving most-recently-generated game into forage, and just always show a link / button somewhere if that has a value
- Translations provided (though German was from DeepL / automated)
- Screenshot!
Shows button on Randomizer settings, if you've generated a game but returned to the Settings part.
Based on feedback from German speaker.
…ue/alttp_vt_randomizer into reconcile-detail-screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.