Pass a block to expect instead of a lambda #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since rspec/rspec-expectations@771da6d rspec will raise if you pass a value trying to use the block expectation.
houndci-bot
reviewed
Oct 3, 2019
| @uri.route_from("http://example.com/") | ||
| end).to raise_error(ArgumentError, /\/\/example.com\//) | ||
| end.to raise_error(ArgumentError, /\/\/example.com\//) |
There was a problem hiding this comment.
Style/RegexpLiteral: Use %r around regular expression.
| @uri.route_to("http://example.com/") | ||
| end).to raise_error(ArgumentError, /\/\/example.com\//) | ||
| expect(lambda do | ||
| end.to raise_error(ArgumentError, /\/\/example.com\//) |
There was a problem hiding this comment.
Style/RegexpLiteral: Use %r around regular expression.
| @uri.route_from("http://example.com/") | ||
| end).to raise_error(ArgumentError, /relative\/path\/to\/resource/) | ||
| end.to raise_error(ArgumentError, /relative\/path\/to\/resource/) |
There was a problem hiding this comment.
Style/RegexpLiteral: Use %r around regular expression.
| @uri.route_to("http://example.com/") | ||
| end).to raise_error(ArgumentError, /relative\/path\/to\/resource/) | ||
| expect(lambda do | ||
| end.to raise_error(ArgumentError, /relative\/path\/to\/resource/) |
There was a problem hiding this comment.
Style/RegexpLiteral: Use %r around regular expression.
The change in rspec-expectations has been reverted, it was released in 3.8.5 but rolled back in 3.8.6. But the change here still might make sense? |
|
I think they do. At least we are saving a few characters 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rspec/rspec-expectations@771da6d rspec will raise if you pass a value trying to use the block expectation.