Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this Weary can't be upgraded to latest addressable gem version
So now we can pass to query_values a hash like:
And get it converted to:
Which query_params will finally convert to:
But this change broke the following tests where the hashes have become valid:
Addressable::URI when assigning query values should raise an error attempting to assign {'a' => {'b' => ['c']}}
Failure/Error: (lambda do
expected TypeError but nothing was raised
./spec/addressable/uri_spec.rb:4925:in `block (2 levels) in <top (required)>'
Addressable::URI when assigning query values should raise an error attempting to assign {:b => '2', :a => {:c => '1'}}
Failure/Error: (lambda do
expected TypeError but nothing was raised
./spec/addressable/uri_spec.rb:4932:in `block (2 levels) in <top (required)>'
Addressable::URI when assigning query values should raise an error attempting to assign {:a => 'a', :b => {:c => true, :d => 'd'}}
Failure/Error: (lambda do
expected TypeError but nothing was raised
./spec/addressable/uri_spec.rb:4959:in `block (2 levels) in <top (required)>'
Addressable::URI when assigning query values should raise an error attempting to assign {:a => 'a', :b => {:c => true, :d => 'd'}}
Failure/Error: (lambda do
expected TypeError but nothing was raised
./spec/addressable/uri_spec.rb:4968:in `block (2 levels) in <top (required)>'
Please advice if this patch is ok and if I should just delete failed tests since their test cases are not valid anymore with this patch.