Drop deprecated RulesDefinitionXmlLoader #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gtoison
commented
May 14, 2022
gtoison
commented
- RulesDefinitionXmlLoader is deprecated and will be dropped in SQ 10
- RulesDefinitionXmlLoader does not populate the OWASP categories and can't be extended (see FindSecBugs rules are not located in proper Security Category in SonarQube #392)
- Loading/unloading the plugins dynamically from jar files leads to file leaks because SpotBugs does not close the classloaders (solves File handle to findsecbugs-plugin.jar is leaking #128)
- The Groovy scripts seem to need some fixes to work with Groovy 4
- RulesDefinitionXmlLoader is deprecated and will be dropped in SQ 10 - RulesDefinitionXmlLoader does not populate the OWASP categories and can't be extended (see spotbugs#392) - Loading/unloading the plugins dynamically from jar files leads to file leaks because SpotBugs does not close the classloaders (solves #128) - The Groovy scripts seem to need some fixes to work with Groovy 4
The sonar-java-plugin is provided by the SonarQube server but not its transient dependencies - Removed usage of Guava - Replaced commons-lang usage by commons-lang3
pethers
approved these changes
May 21, 2022
|
Sorry, just realized I forgot to commit the deletion of code and resources that are now unused |
pethers
approved these changes
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.