Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close plugins at the end of the analysis #696

Merged
merged 3 commits into from
Dec 17, 2022
Merged

fix: close plugins at the end of the analysis #696

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e71c28b
fix: close plugins at the end of the analysis
gtoison Dec 17, 2022
7d6e19d
fix: reverted organize imports to reduce the diff
gtoison Dec 17, 2022
5a8feed
Merge remote-tracking branch 'origin/master' into close-plugins
gtoison Dec 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/org/sonar/plugins/findbugs/FindbugsExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,15 @@ private static void resetCustomPluginList(Collection<Plugin> customPlugins) {
if (customPlugins != null) {
for (Plugin plugin : customPlugins) {
Plugin.removeCustomPlugin(plugin);

try {
// We have copied the plugin jar in the project's build directory
// Now we need to close the classloaders pointing to that jar
// so we do not prevent the deletion of the build folder
plugin.close();
} catch (IOException e) {
LOG.error("Error closing plugin", e);
}
}
}
}
Expand Down