Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sb-contrib to 7.6.4 #906

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

gtoison
Copy link
Contributor

@gtoison gtoison commented Dec 22, 2023

No description provided.

@gtoison
Copy link
Contributor Author

gtoison commented Dec 22, 2023

This should fail due to mebigfatguy/fb-contrib#456 but it doesn't

@hazendaz
Copy link
Member

hazendaz commented Jan 2, 2024

That was for the gradle plugin. This clearly is ok. So was maven. Gradle seems so much more finicky then other build tools. Are you wanting to merge this or just update to 7.6.4 which is also out?

@gtoison
Copy link
Contributor Author

gtoison commented Jan 2, 2024

There are analysis errors thrown by sb-contrib and they should be reported somewhere else than in the logs.
Currently the SpotBugs plugin only logs the analysis errors, this is only visible to someone looking at the build logs. I'll try to see if I can report them in a better way so they are visible in Sonarqube

@gtoison gtoison changed the title Upgrade sb-contrib to 7.6.3 Upgrade sb-contrib to 7.6.4 Jan 2, 2024
@gtoison gtoison merged commit 3374782 into spotbugs:master Jan 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants