Skip to content

Commit

Permalink
fix: Gradle plugin should require JVM 8 but require JVM 11 (#1074)
Browse files Browse the repository at this point in the history
* ci: fix the base config for renovate

Signed-off-by: Kengo TODA <toda_k@henry.jp>

* ci: introduce a GitHub Action to verify commit comments

Signed-off-by: Kengo TODA <toda_k@henry.jp>

* fix: Gradle plugin requires JVM 8

Signed-off-by: Kengo TODA <toda_k@henry.jp>

* ci: skip verification in case of push

Signed-off-by: Kengo TODA <toda_k@henry.jp>

---------

Signed-off-by: Kengo TODA <toda_k@henry.jp>
  • Loading branch information
KengoTODA authored Dec 15, 2023
1 parent b3b17a3 commit 7710423
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: webiny/action-conventional-commits@v1.1.0
if: github.event_name == 'pull_request'
- name: Set up JDK
uses: actions/setup-java@v4
with:
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ You can change SpotBugs version by [the `toolVersion` property of the spotbugs e

| Gradle Plugin | SpotBugs |
|--------------:|---------:|
| 6.0.3 | 4.8.3 |
| 6.0.0 | 4.8.2 |
| 5.2.5 | 4.8.2 |
| 5.2.3 | 4.8.1 |
Expand Down Expand Up @@ -209,7 +210,7 @@ dependencies {

## Development
### Setup
* development requires java 11 or higher to be installed
* development requires java 17 or higher to be installed
* The CI server uses `ubuntu-latest` docker image, but you should be able to develop on any linux/unix based OS.
* before creating commits
* read https://www.conventionalcommits.org/en
Expand Down
2 changes: 1 addition & 1 deletion renovate.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"config:base"
"config:recommended"
]
}

0 comments on commit 7710423

Please sign in to comment.