Kotlin idioms #1063
Merged
Kotlin idioms #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
commented
Dec 5, 2023
|
This depends on #1064, merge that first. |
Goooler
force-pushed
the
fix-detekt-rules
branch
from
f7e5ea1 to
e342e99
Compare
Goooler
force-pushed
the
fix-detekt-rules
branch
from
e342e99 to
60b7d3e
Compare
KengoTODA
requested changes
Dec 7, 2023
src/main/kotlin/com/github/spotbugs/snom/internal/SpotBugsRunnerForHybrid.kt
Show resolved
Hide resolved
src/main/kotlin/com/github/spotbugs/snom/internal/SpotBugsRunnerForJavaExec.kt
Show resolved
Hide resolved
|
If we are ready to land this, may merge #1064 first, then rebase this to check the API changes. |
KengoTODA
approved these changes
Dec 7, 2023
|
🎉 This PR is included in version 6.0.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all Detekt issues and replaces some Java APIs with Kotlin idioms.
Follow up #924.