Allow projects without a SourceSet (Eg. Android) to use this SpotBugs… #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Task If a project does not contain a sourceset, the execution of type SpotBugsTask fails with `path may not be null or empty string. path='null'` error. This is because the sourceset is passed as an `@InputFiles` and it is null.
KengoTODA
requested changes
May 30, 2019
There was a problem hiding this comment.
Thanks for your PR! Could you consider to:
- Update
CHANGELOG.mdbased on Keep a Changelog 1.0.0 - Make an unit test to reproduce your problem, then we can make sure that this feature won't be broken in future.
|
Sure... Will try to add them up over the weekend. |
|
is there any update for this one? thanks! |
|
version 4 should work even for Android project with plugin version 3.5, please have a try. but it seems that Android plugin 3.6 removed task so this plugin doesn't work: #194 |
|
The Android Gradle Plugin version is available as a static field in the JAR. This is how the Android Pitest plugin does it: https://github.com/koral--/gradle-pitest-plugin/blob/master/src/main/groovy/pl/droidsonroids/gradle/pitest/PitestPlugin.groovy#L37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Task
If a project does not contain a sourceset, the execution of type SpotBugsTask fails with
path may not be null or empty string. path='null'error.This is because the sourceset is passed as an
@InputFilesand it is null.