Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use task creation avoidance api #234

Merged
merged 1 commit into from
Apr 26, 2020
Merged

fix: Use task creation avoidance api #234

merged 1 commit into from
Apr 26, 2020

Conversation

daanschipper
Copy link
Contributor

@daanschipper daanschipper commented Apr 24, 2020

Using getTasks().register() avoids creating the tasks during configuration time.
Currently the plugin is creating number of modules * number of sourcesets amount of tasks, slowing down the configuration time.

Tasks created during configuration time, from a build scan

How can I build the plugin to test it locally to confirm that this solves the issue?

@daanschipper daanschipper changed the title Use task creation avoidance api fix: Use task creation avoidance api Apr 24, 2020
@KengoTODA
Copy link
Member

Confirmed that this fix can pass existing test cases, then #196 won't be reproduced by this change. This means that #204 is the necessary fix and #199 isn't, actually.

Thank you!

How can I build the plugin to test it locally to confirm that this solves the issue?

The suggested way is to make integration tests instead of the manual checks.
It is also possible to install the artifact to the local maven repository.

For this PR, it seems safe to merge, then I'll merge this for performance enhancements.

@KengoTODA KengoTODA added the bug label Apr 26, 2020
@KengoTODA KengoTODA merged commit ed1cecf into spotbugs:master Apr 26, 2020
@KengoTODA
Copy link
Member

semantic-release didn't trigger a release, because I forgot to use 'squash and merge' which uses PR name as commit comment, instead of 'rebase and merge'. I will release the next patch version later.

https://github.com/spotbugs/spotbugs-gradle-plugin/runs/619575381#step:8:55

KengoTODA pushed a commit that referenced this pull request Apr 26, 2020
@KengoTODA
Copy link
Member

v4.0.6 contains this fix.

https://github.com/spotbugs/spotbugs-gradle-plugin/releases/tag/4.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants