Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of internal class ClosureBackedAction #51

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

rbaradari
Copy link
Contributor

In a commit for Gradle 5.0 the internal class org.gradle.api.internal.ClosureBackedAction
has been moved to org.gradle.util.ClosureBackedAction`
(see gradle/gradle@b164790#diff-bd993f7b907baefcd8fcf66327841ed4).

This commit replaces the usage of ClosureBackedAction with org.gradle.util.ConfigureUtil.configureUsing()
which is available for a long time.

This fixes an exception when the plugin is used nightly builds of Gradle 5.0:
java.lang.NoClassDefFoundError: org/gradle/api/internal/ClosureBackedAction

In a commit for Gradle 5.0 the internal class `org.gradle.api.internal.ClosureBackedAction` 
has been moved to org.gradle.util.ClosureBackedAction` 
(see gradle/gradle@b164790#diff-bd993f7b907baefcd8fcf66327841ed4).

This commit replaces the usage of `ClosureBackedAction` with `org.gradle.util.ConfigureUtil.configureUsing()`
which is available for a long time.

This fixes an exception when the plugin is used nightly builds of Gradle 5.0:
`java.lang.NoClassDefFoundError: org/gradle/api/internal/ClosureBackedAction`
Copy link
Member

@KengoTODA KengoTODA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@KengoTODA KengoTODA merged commit a3a9f4a into spotbugs:master Sep 20, 2018
KengoTODA pushed a commit that referenced this pull request Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants