-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump default spotbugs version from 4.7.1 to 4.7.2 #783
Conversation
…s core Signed-off-by: Kengo TODA <toda_k@bw-company.com>
Signed-off-by: Kengo TODA <toda_k@bw-company.com>
Signed-off-by: Kengo TODA <toda_k@bw-company.com>
README.md
Outdated
| 4.0.0| 4.0.0| | ||
| Gradle Plugin | SpotBugs | | ||
|--------------:|---------:| | ||
| 5.0.13 | 4.7.2 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDEA did a magic so many lines are got affected, however, what actually changed is here: simply added a mapping 5.0.13 to 4.7.2
.
Signed-off-by: Kengo TODA <toda_k@bw-company.com>
Kudos, SonarCloud Quality Gate passed! |
@KengoTODA Thanks for addition information here. Appreciate it! |
🎉 This PR is included in version 5.0.12 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@KengoTODA Can you explain a bit better here as to why 'fix' is used? Why not 'release' as a prefix as we want to release it. Are there different types with this setup already? What foo magic is making this happen? Others have done this on spotbugs plugin and it releases nothing. So its confusing at best. It should be directly documented as release steps and IMHO, it should not be happening on master even. Everyone raises PRs to master, if I did not know about this now, what was to stop some rouge user from raising a PR with 'fix' on it causing it to release on us. |
Thanks for merging #782!
When we bump up the dependency on spotbugs-core, it is better to:
fix:
prefixPlease merge this PR by
squash and merge
and make sure its commit message starts withfix:
then next release will be made by Gradle automatic.