Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump default spotbugs version from 4.7.1 to 4.7.2 #783

Merged
merged 4 commits into from
Sep 6, 2022

Conversation

KengoTODA
Copy link
Member

Thanks for merging #782!

When we bump up the dependency on spotbugs-core, it is better to:

  1. update the README.md to tell the mapping between versions of gradle-plugin and spotbugs-core,
  2. trigger a release by make a commit with fix: prefix

Please merge this PR by squash and merge and make sure its commit message starts with fix: then next release will be made by Gradle automatic.

…s core

Signed-off-by: Kengo TODA <toda_k@bw-company.com>
Signed-off-by: Kengo TODA <toda_k@bw-company.com>
@KengoTODA KengoTODA requested a review from hazendaz September 6, 2022 00:20
@KengoTODA KengoTODA self-assigned this Sep 6, 2022
Signed-off-by: Kengo TODA <toda_k@bw-company.com>
README.md Outdated
| 4.0.0| 4.0.0|
| Gradle Plugin | SpotBugs |
|--------------:|---------:|
| 5.0.13 | 4.7.2 |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDEA did a magic so many lines are got affected, however, what actually changed is here: simply added a mapping 5.0.13 to 4.7.2.

Signed-off-by: Kengo TODA <toda_k@bw-company.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hazendaz hazendaz merged commit 23dd87f into master Sep 6, 2022
@hazendaz hazendaz deleted the release-new-patch-ver branch September 6, 2022 01:22
@hazendaz
Copy link
Member

hazendaz commented Sep 6, 2022

@KengoTODA Thanks for addition information here. Appreciate it!

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

🎉 This PR is included in version 5.0.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hazendaz
Copy link
Member

@KengoTODA Can you explain a bit better here as to why 'fix' is used? Why not 'release' as a prefix as we want to release it. Are there different types with this setup already? What foo magic is making this happen? Others have done this on spotbugs plugin and it releases nothing. So its confusing at best. It should be directly documented as release steps and IMHO, it should not be happening on master even. Everyone raises PRs to master, if I did not know about this now, what was to stop some rouge user from raising a PR with 'fix' on it causing it to release on us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants