Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auxiliary classpath is broken #549

Closed
corebonts opened this issue Feb 24, 2023 · 2 comments
Closed

Auxiliary classpath is broken #549

corebonts opened this issue Feb 24, 2023 · 2 comments
Assignees
@hazendaz

Comments

@corebonts
Copy link

corebonts commented Feb 24, 2023 •
edited
Loading

The plugin versions before 4.7.3.1 passed the auxiliary classpath via the standard input, which caused a deadlock during parallel builds with non-forked spotbugs. #488

Although this was fixed by removing the -auxclasspathFromInput, this broke the classpath logic.

The solution is to pass the classpath using a file. (merge request is approaching soon)

     [java] The following classes needed for analysis were missing:
     [java]   com.google.inject.AbstractModule
     [java]   javax.servlet.http.HttpServlet
     [java]   javax.servlet.Filter
     [java]   com.google.inject.servlet.ServletModule
     [java]   javax.servlet.http.HttpServletRequest
     [java]   javax.servlet.http.HttpServletResponse
     [java]   okhttp3.internal.http.HttpMethod
     [java]   com.google.common.io.ByteStreams
     [java]   javax.servlet.ServletInputStream
     [java]   com.google.common.base.Joiner
     [java]   javax.servlet.ServletOutputStream
     [java]   com.google.common.base.Strings
...
corebonts pushed a commit to corebonts/spotbugs-maven-plugin that referenced this issue Feb 24, 2023
spotbugs#549 Pass the auxiliary classpath using the -auxclasspathFrom…
6a9bb44 
…File argument

The plugin versions before 4.7.3.1 passed the auxiliary classpath via the
standard input, which caused a deadlock during parallel builds with
non-forked spotbugs. spotbugs#488

Although this was fixed by removing the -auxclasspathFromInput, this broke the
classpath logic.

The solution is to pass the classpath using a file.
This was referenced Feb 25, 2023
Closed
Merged
@hazendaz
Copy link
Member

fix in the works...

hazendaz added a commit that referenced this issue Feb 25, 2023
@hazendaz
Merge pull request #550 from corebonts/488-auxclasspath
03a2658 
#549 Pass the auxiliary classpath using the -auxclasspathFromFile agument
@hazendaz
Copy link
Member

fixed in master now. Writing tests to ensure this does not happen again in future. No current IT tests checked for any such condition giving false positive this was ok for changing.

@hazendaz hazendaz self-assigned this Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hazendaz hazendaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hazendaz @corebonts