Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume ASM 6.0 BETA #268

Closed
iloveeclipse opened this issue Jul 17, 2017 · 12 comments
Closed

Consume ASM 6.0 BETA #268

iloveeclipse opened this issue Jul 17, 2017 · 12 comments
Assignees

Comments

@iloveeclipse
Copy link
Member

ASM project just released 6.0 BETA binaries, we schould make sure we use them.

@sewe
Copy link

sewe commented Jul 18, 2017

I will have a look.

@iloveeclipse
Copy link
Member Author

Thanks Andreas.
P.S. I'm pretty overloaded right now, so I have no time for pending reviews.

@sewe
Copy link

sewe commented Jul 18, 2017

Thanks Andreas.

May take a bit here as well; the Maven Central promotion is still pending.

P.S. I'm pretty overloaded right now, so I have no time for pending reviews.

No problem. I’ll reach out to one of the other committers.

@iloveeclipse
Copy link
Member Author

@KengoTODA : I'm not a maven expert/user , I don't know how complicated it is to update the ASM version - but it would be great if this would be in RC4.

@sewe
Copy link

sewe commented Jul 21, 2017

I'm not a maven expert/user , I don't know how complicated it is to update the ASM version - but it would be great if this would be in RC4.

@iloveeclipse On our side, Maven would not be involved. (Gradle and grep would.)

But apparently the ASM guys are facing a delay with their promotion to Maven Central. I’ll keep an eye on their mailing list.

@KengoTODA
Copy link
Member

It has not been published to Maven central yet, let's handle it in RC5 or later

@iloveeclipse
Copy link
Member Author

Yep. They still have trouble promoting the build via the new infrastructure in ASM.

@don-vip
Copy link
Contributor

don-vip commented Aug 4, 2017

It seems finally available on Maven Central: http://repo1.maven.org/maven2/org/ow2/asm/asm/6.0_BETA/

@sewe
Copy link

sewe commented Aug 4, 2017

@don-vip Great. I’ll have a look at doing the update then.

sewe pushed a commit to sewe/spotbugs that referenced this issue Aug 4, 2017
@sewe
Copy link

sewe commented Aug 4, 2017

Commit 6491753 so far is just a quick search & replace. I haven’t done any in-depth testing; hence, no pull request yet.

@sewe
Copy link

sewe commented Aug 6, 2017

Pull request is here: #303.

@sewe sewe removed the help wanted label Aug 6, 2017
iloveeclipse pushed a commit that referenced this issue Aug 9, 2017
@iloveeclipse
Copy link
Member Author

Closed by #303. Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants