This repository has been archived by the owner on Mar 31, 2022. It is now read-only.
Add atomic modifyRepairRun method to storage #96
+169
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As you said, we could also utilise Postgres functions and LANGUAGE sql or plpgsql. In general, if using databases that will live longer, and be extended during the lifetime, it makes sense to use database functions for everything. Using database side functions creates an abstraction layer that is usable for separating DBA and developer concerns, making it easy to optimise the database side separately from the code, change the schema, add support for sharding, etc. easier. |
Also, marking updateRepairRun as deprecated. The next step is to replace all uses of that method with the new one, and then remove updateRepairRun from IStorage.
Bj0rnen
force-pushed
the
Bj0rnen/ModifyRepairRun
branch
from
61bd4ce to
3457d92
Compare
Bj0rnen
pushed a commit
that referenced
this pull request
May 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, marking updateRepairRun as deprecated. The next step is to
replace all uses of that method with the new one, and then remove
updateRepairRun from IStorage.
I think that the postgress storage version can probably be implemented in a better way, using transactions rather than locks. But the current approach should be correct.