Fix png sizing #172
Merged
Fix png sizing #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in either Selenium or the ChromeDriver causes the lower parts of charts to be cropped in the png output. The Bokeh `get_screenshot_as_png` has some smarter calculations to overcome this. Plus it also allows a scale factor to improve output resolution.
landryzs
reviewed
Oct 15, 2024
|
Removed Python3.8 and added 3.11 in some different places, prepped for a release 5.0.0 (as we are dropping support for 3.8) and added support to use make black for code formatting. Is it possible for you @jhyching to change the target of this PR to the branch |
tjofas
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix bad cropping of
pngand add a bit more functionality.Which issue(s) this PR fixes
Fixes bad cropping in
pngintroduced by changes to chrome webdriver.Special notes for your reviewer:
Release note: