Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle INT UNSIGNED column types. #380

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

rulle-io
Copy link
Contributor

Fix for #294 , where dbeam cannot handle UNSIGNED INT column type values more than INTEGER.MAX_VALUE (2147483647L).

It seems like the most appropriate property to select correct Avro type is to use ResultSetMetaData.getColumnClassName() method.

image

Tests

  • "Unit tests included"
  • "I successfully ran my jobs with this code"

Checklist for PR author(s)

  • Changes are covered by unit tests (no major decrease in code coverage %) and/or integration tests.
  • Ensure code formating (use mvn com.coveo:fmt-maven-plugin:format org.codehaus.mojo:license-maven-plugin:update-file-header)
  • Document any relevant additions/changes in the appropriate spot in javadocs/docs/README.

@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #380 (f22e21f) into master (2315e22) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #380      +/-   ##
============================================
+ Coverage     91.42%   91.57%   +0.15%     
- Complexity      241      244       +3     
============================================
  Files            26       26              
  Lines           921      938      +17     
  Branches         65       69       +4     
============================================
+ Hits            842      859      +17     
  Misses           52       52              
  Partials         27       27              

@rulle-io
Copy link
Contributor Author

@labianchin

@rulle-io
Copy link
Contributor Author

Closes #294 .

@rulle-io rulle-io linked an issue Jan 18, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling of unsigned int fields in MySQL
2 participants