This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Fix bug when duplicate registries are in docker config #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1100 +/- ##
=========================================
Coverage ? 70.17%
Complexity ? 791
=========================================
Files ? 178
Lines ? 3772
Branches ? 393
=========================================
Hits ? 2647
Misses ? 960
Partials ? 165 |
mattnworb
approved these changes
Oct 25, 2018
|
@mattnworb yup, see the test here. |
|
cc @spotify/docker-admins |
davidxia
added a commit
to spotify/dockerfile-maven
that referenced
this pull request
Oct 25, 2018
to pick up this fix spotify/docker-client#1100.
davidxia
added a commit
to spotify/dockerfile-maven
that referenced
this pull request
Oct 25, 2018
to pick up this fix spotify/docker-client#1100. Update CHANGELOG.
This was referenced Nov 13, 2018
Closed
Closed
This was referenced Jan 16, 2019
Closed
Closed
cyrusv
added a commit
to cyrusv/common
that referenced
this pull request
May 17, 2019
This version includes the following fixes from their changelog: 1.4.9 (released October 25 2018) - Upgrade docker-client dep from 8.14.2 to 8.14.3 to fix spotify/docker-client#1100 1.4.8 (released October 23 2018) - Upgrade docker-client dep from 8.14.0 to 8.14.2 - Upgrade com.sparkjava:spark-core to fix CVE-2018-9159 - Improve documentation on referencing build artifacts Some of these fixes allow legal docker configs to build correctly, which the current version throws errors on.
cyrusv
added a commit
to confluentinc/common
that referenced
this pull request
May 20, 2019
This version includes the following fixes from their changelog: 1.4.9 (released October 25 2018) - Upgrade docker-client dep from 8.14.2 to 8.14.3 to fix spotify/docker-client#1100 1.4.8 (released October 23 2018) - Upgrade docker-client dep from 8.14.0 to 8.14.2 - Upgrade com.sparkjava:spark-core to fix CVE-2018-9159 - Improve documentation on referencing build artifacts Some of these fixes allow legal docker configs to build correctly, which the current version throws errors on.
This was referenced May 24, 2019
This was referenced Jul 30, 2019
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes spotify/dockerfile-maven#236