Skip to content
This repository was archived by the owner on Mar 21, 2022. It is now read-only.

Conversation

@davidxia
Copy link
Contributor

@davidxia davidxia commented Nov 9, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 9, 2016

Current coverage is 46.28% (diff: 22.22%)

Merging #537 into master will decrease coverage by 0.02%

@@             master       #537   diff @@
==========================================
  Files           130        130          
  Lines          4312       4319     +7   
  Methods           0          0          
  Messages          0          0          
  Branches        636        635     -1   
==========================================
+ Hits           1997       1999     +2   
- Misses         2124       2130     +6   
+ Partials        191        190     -1   

Powered by Codecov. Last update 73692c0...67cfd6e

@davidxia
Copy link
Contributor Author

davidxia commented Nov 9, 2016

@mattnworb @CGNonofr

Copy link
Member

@mattnworb mattnworb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CGNonofr and others added 4 commits November 9, 2016 16:00
Split it into `isLinux()` and `isOsX()`.
Use os.name system property instead of file separator to decide.
so we don't run this test which will fail on linux kernels <= 4.3.
@davidxia davidxia force-pushed the dxia/hostconfig-pidslimit branch from f632622 to 67cfd6e Compare November 9, 2016 21:01
@davidxia davidxia merged commit 7140b48 into master Nov 9, 2016
@davidxia davidxia deleted the dxia/hostconfig-pidslimit branch November 9, 2016 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants