This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
GCR: ignore exceptions when building images #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will prevent unexpected exceptions in cases where the Application Default Credentials are loaded (for example: if running in GCE) but where the credentials do not have the |
|
👍 |
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
============================================
+ Coverage 65.27% 65.49% +0.21%
- Complexity 674 675 +1
============================================
Files 156 156
Lines 2955 2965 +10
Branches 340 340
============================================
+ Hits 1929 1942 +13
+ Misses 876 873 -3
Partials 150 150 |
Ignore exceptions refreshing the accessToken in ContainerRegistryAuthSupplier when building the image or getting the RegistryAuth to be used for swarm. Since `authForBuild()` has no arguments, we currently try to return an AccessToken to use _in case_ the image being built needs to pull from gcr.io, but we should ignore failures in the case that the image being built does not need to pull anything from gcr.io. This way someone using ContainerRegistryAuthSupplier with credentials that do not actually have access to GCR do not get exceptions when building non-GCR images. If the accessToken can't be fetched in `authForBuild` for a gcr.io image, then the build will still fail but at a later point when the docker daemon tries to pull the FROM image and throws an error about how the image is "missing or access is denied".
mattnworb
force-pushed
the
mattbrown/ignore-some-gcr-auth-exceptions
branch
from
deb5a5d to
023246d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore exceptions refreshing the accessToken in
ContainerRegistryAuthSupplier when building the image or getting the
RegistryAuth to be used for swarm.
Since
authForBuild()has no arguments, we currently try to return anAccessToken to use in case the image being built needs to pull from
gcr.io, but we should ignore failures in the case that the image being
built does not need to pull anything from gcr.io.
This way someone using ContainerRegistryAuthSupplier with credentials
that do not actually have access to GCR do not get exceptions when
building non-GCR images.
If the accessToken can't be fetched in
authForBuildfor a gcr.ioimage, then the build will still fail but at a later point when the
docker daemon tries to pull the FROM image and throws an error about how
the image is "missing or access is denied".