useConfigFile now used as fall-back if settings exists, but server is…

[ghost]

If a settings.xml file is found, but no appropriate <server> is found, the useConfigFile parameter was skipped.

This request allows the check for useConfigFile to be used as a "last-ditch" for authentication.

[vromero]

Without this, useConfigFile is almost useless.
Any chance this could be reviewed?

[ghost]

@vromero I see your point - yes, it does pretty much render it useless.

Reflecting on it a bit, looking at the original commit (and searching my rusty memory), there is a purpose: if you have a configFile, but don't want to use it (for various reaons), then the flag prevents it from happening. Thus it's not simply gated on the existence of the file.

[vromero]

I see. I think it would be fair to say that the ideal behavior should be to look both in the settings.xml and in the file (that could be manually disabled), or having two flags: useMavenSettings useConfigFile (although this would be trickier because require more changes) for people that have invalid credentials in the settings for whatever reason, and want to force the use of the file.

[mattnworb]

Thanks for the PR, but in #339 we will be making the docker config file always be used if it exists, as that seems more definitive and a better source of this configuration information than the maven pom.

[ghost]

👍