Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

Add support for --squash experimental build option #248

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Add support for --squash experimental build option #248

merged 1 commit into from
Nov 19, 2018

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Nov 12, 2018

Fixes #213

@matthyx
Copy link
Contributor Author

matthyx commented Nov 12, 2018

Looks like a flake... how do I restart a failed build?

@matthyx
Copy link
Contributor Author

matthyx commented Nov 15, 2018

@mattnworb or @davidxia can you have a look? I would really like to use that feature (and not rely on a snapshot for that).

davidxia
davidxia reviewed Nov 15, 2018
View reviewed changes
Copy link
Contributor

@davidxia davidxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Could you update the docs here and also specify which versions of Docker support this?

Also update the CHANGELOG and start a new section for the upcoming release and mention this feature.

@matthyx
Copy link
Contributor Author

matthyx commented Nov 15, 2018

@davidxia thanks a lot, let me update that this afternoon.

@matthyx
Copy link
Contributor Author

matthyx commented Nov 19, 2018

@davidxia will you have time this week?

@davidxia
Copy link
Contributor

Sorry for the delay. Thanks for the reminder. LGTM!

@davidxia davidxia merged commit 230dd09 into spotify:master Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidxia davidxia davidxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthyx @davidxia