This repository has been archived by the owner on Mar 31, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a build argument contains the space character, that's replaced by the
+
character.This is due to
dockerfile-maven/plugin/src/main/java/com/spotify/plugin/dockerfile/BuildMojo.java
Lines 291 to 297 in 986f960
URLEncoder
. Indeed, we can read here thatURLEncoder
replaces the space character " " with a plus sign "+".After the encoding, I added a replace to substitute the
+
sign with a space: after the encoding all the plus signs will be already encoded to/0x2B
, so the ones left are the ones are coming from spaces.I expanded the test case to make sure that everything will continue to work in the future.
Let me know if you need additional info.
Fixes #136
Fixes #286