This repository has been archived by the owner on Mar 31, 2022. It is now read-only.
allow disabling of Google Container Registry credential checks #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…maven into jeremyweber-np-DM-34
`googleContainerRegistryEnabled` seems more maven idiomatic
dflemstr
suggested changes
Jul 10, 2017
| } | ||
| } catch (IOException ex) { | ||
| getLog().info("ignoring exception while loading Google credentials", ex); | ||
| if (googleContainerRegistryEnabled){ |
There was a problem hiding this comment.
Missing space in front of { ;)
| getLog().info("ignoring exception while loading Google credentials", ex); | ||
| } | ||
| } else { | ||
| getLog().info("Google Container Registry support is disabled"); |
There was a problem hiding this comment.
there is an info line already in googleContainerRegistryAuthSupplier when credentials are successfully loaded, so i wanted to have some parity
| * can be explicitly disabled with this property if needed. | ||
| */ | ||
| @Parameter(defaultValue = "true", property = "dockerfile.googleContainerRegistryEnabled") | ||
| private boolean googleContainerRegistryEnabled = true; |
There was a problem hiding this comment.
No need to have both defaultValue = ... and assign a default value
| suppliers.add(0, googleSupplier); | ||
| } | ||
| } catch (IOException ex) { | ||
| getLog().info("ignoring exception while loading Google credentials", ex); |
dflemstr
approved these changes
Jul 10, 2017
This was referenced Jul 10, 2017
Closed
|
I released version 1.3.3 of the plugin a few minutes ago with this change in it. |
kilianpg
added a commit
to Arquisoft/Agents_e3b
that referenced
this pull request
Apr 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #35; I added a commit addressing my own feedback to be able to merge and release this quicker.