-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please allow skip of sourceDirectory or testSourceDirectory #31
Comments
camac
added a commit
to camac/fmt-maven-plugin
that referenced
this issue
Feb 16, 2022
Fixes spotify#31 Adds 2 extra configuration options controlling whether to skip relevant directories: - skipSourceDirectory - skipTestSourceDirectory Tests added: - check_skipsourcedirectory: Tests that sourceDirectory is skipped for check goal when skipSourceDirectory is true. sourceDirectory includes unformatted code so it would fail if not skipped. - check_skiptestsourcedirectory: Tests that testSourceDirectory is skipped for check goal when skipTestSourceDirectory is true. testSourceDirectory includes unformatted code so it would fail if not skipped. - skipsourcedirectory: Tests that sourceDirectory files are not formatted with format goal when skipSourceDirectory is true. - skiptestsourcedirectory: Tests that testSourceDirectory files are not formatted with format goal when skipTestSourceDirectory is true.
camac
added a commit
to camac/fmt-maven-plugin
that referenced
this issue
Mar 1, 2022
Fixes spotify#31 Adds 2 extra configuration options controlling whether to skip relevant directories: - skipSourceDirectory - skipTestSourceDirectory Tests added: - check_skipsourcedirectory: Tests that sourceDirectory is skipped for check goal when skipSourceDirectory is true. sourceDirectory includes unformatted code so it would fail if not skipped. - check_skiptestsourcedirectory: Tests that testSourceDirectory is skipped for check goal when skipTestSourceDirectory is true. testSourceDirectory includes unformatted code so it would fail if not skipped. - skipsourcedirectory: Tests that sourceDirectory files are not formatted with format goal when skipSourceDirectory is true. - skiptestsourcedirectory: Tests that testSourceDirectory files are not formatted with format goal when skipTestSourceDirectory is true. Co-authored-by: Sean Flanigan <sflanigan@securecodewarrior.com>
caesar-ralf
pushed a commit
that referenced
this issue
Sep 30, 2022
* Allow skipping of sourceDirectory or testSourceDirectory Fixes #31 Adds 2 extra configuration options controlling whether to skip relevant directories: - skipSourceDirectory - skipTestSourceDirectory Tests added: - check_skipsourcedirectory: Tests that sourceDirectory is skipped for check goal when skipSourceDirectory is true. sourceDirectory includes unformatted code so it would fail if not skipped. - check_skiptestsourcedirectory: Tests that testSourceDirectory is skipped for check goal when skipTestSourceDirectory is true. testSourceDirectory includes unformatted code so it would fail if not skipped. - skipsourcedirectory: Tests that sourceDirectory files are not formatted with format goal when skipSourceDirectory is true. - skiptestsourcedirectory: Tests that testSourceDirectory files are not formatted with format goal when skipTestSourceDirectory is true. Co-authored-by: Sean Flanigan <sflanigan@securecodewarrior.com> * Apply suggestions from code review Co-authored-by: Klara <klara@kth.se> * Use loadMojo * Add invoker.properties for skip directory tests * Update groupId to com.spotify.fmt for skip directory test pom.xml Co-authored-by: Sean Flanigan <sflanigan@securecodewarrior.com> Co-authored-by: Klara <klaraw@spotify.com> Co-authored-by: Klara <klara@kth.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In my use case, I would like to skip the format of the default testSourceDirectory. Is there a way to do it (other than add a fake directory as testSourceDirectory)?
The text was updated successfully, but these errors were encountered: