Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change groupId and package to com.spotify.fmt #124

Merged
merged 10 commits into from
Feb 21, 2022
Merged

Change groupId and package to com.spotify.fmt #124

merged 10 commits into from
Feb 21, 2022

Conversation

klaraward
Copy link
Contributor

@klaraward klaraward commented Feb 15, 2022 •
edited
Loading

Fixes #124

Not sure how we should handle the developer section going forward.

Need to sort out relocation before merging this and making new releases - #129

caesar-ralf
caesar-ralf suggested changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@caesar-ralf caesar-ralf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the packages changed, but didn't move the files

src/main/java/com/coveo/AbstractFMT.java Outdated Show resolved Hide resolved
src/test/resources/additionalfolders/pom.xml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@klaraward klaraward marked this pull request as draft February 15, 2022 10:54
herder
herder suggested changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@herder herder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The java files have only gotten their package changed, but not been moved to the com.spotify directory. But for some reason the build doesn't fail?
Either way we should probably move them :)

@klaraward
Copy link
Contributor Author

The java files have only gotten their package changed, but not been moved to the com.spotify directory. But for some reason the build doesn't fail? Either way we should probably move them :)

No idea why it doesn't fail, but moved now.

herder
herder reviewed Feb 15, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@klaraward @herder
Update coveooss -> spotify move info
6d8b450 
Co-authored-by: Niklas Herder <niklas.herder@gmail.com>
caesar-ralf
caesar-ralf approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@caesar-ralf caesar-ralf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing there, but LGTM besides it

README.md Outdated Show resolved Hide resolved
@herder herder self-requested a review February 17, 2022 12:16
@klaraward klaraward mentioned this pull request Feb 21, 2022
Open
@klaraward @caesar-ralf
Update groupId in maven badge link
54de95d 
Co-authored-by: Caesar Ralf Franz Hoppen <caesar.ralf@gmail.com>
@klaraward klaraward marked this pull request as ready for review February 21, 2022 14:20
@klaraward klaraward merged commit d2dc5f3 into main Feb 21, 2022
@klaraward klaraward deleted the spotify branch February 21, 2022 15:26
@klaraward klaraward changed the title Change groupId and package to com.spotify Change groupId and package to com.spotify.fmt Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herder herder herder approved these changes

@caesar-ralf caesar-ralf caesar-ralf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klaraward @herder @caesar-ralf