Skip to content
This repository has been archived by the owner on Mar 27, 2021. It is now read-only.

[pubsub] use latest version of netty-tcnative-boringssl #599

Merged
merged 2 commits into from
Jan 24, 2020

Conversation

dmichel1
Copy link
Contributor

Otherwise when the pubsub connection is setup with SSL there is a run time error. Not quite sure how the dependency tree changed with Netty when the elasticsearch library was updated since the Netty version was always pinned 🤔.

Otherwise when the pubsub connection is setup with SSL there is a run time error. Not quite sure how the dependency tree changed with Netty when the elasticsearch library was updated since the Netty version was always pinned.
@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #599 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #599      +/-   ##
============================================
- Coverage     51.54%   51.53%   -0.02%     
+ Complexity     2859     2858       -1     
============================================
  Files           727      727              
  Lines         19424    19424              
  Branches       1289     1289              
============================================
- Hits          10012    10010       -2     
- Misses         8985     8986       +1     
- Partials        427      428       +1
Impacted Files Coverage Δ Complexity Δ
...com/spotify/heroic/aggregation/simple/MaxBucket.kt 44.44% <0%> (-11.12%) 4% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update decbf61...c0488bd. Read the comment docs.

@dmichel1 dmichel1 merged commit 1ba241c into master Jan 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the dmichel/pubsub-runtime branch January 24, 2020 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants