This repository has been archived by the owner on Mar 27, 2021. It is now read-only.
Scope request spans so that they link to coreQueryManager. #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmuhlha
approved these changes
Mar 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #621 +/- ##
=========================================
Coverage 52.85% 52.85%
Complexity 2928 2928
=========================================
Files 728 728
Lines 19449 19449
Branches 1290 1290
=========================================
Hits 10280 10280
Misses 8731 8731
Partials 438 438
Continue to review full report at Codecov.
|
dmichel1
reviewed
Mar 13, 2020
| @@ -188,9 +186,10 @@ public void onEvent(RequestEvent event) { | |||
| invocable.getDefinitionMethod())); | |||
|
|
|||
| final String spanName = invocable.getHandler().getHandlerClass().getName(); | |||
| resourceSpan = globalTracer | |||
| globalTracer | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is the final part to close out #505. I also fixed the
findSeriesspan so that its end time encompasses thefetchchild spans.