This repository has been archived by the owner on Mar 27, 2021. It is now read-only.
Codestyle: update from 6.x to 8.x (see precursor #720) #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also upgraded 6.13 → 8.37
sming
added
the
codebase quality
Basically some modules changed parent and others were retired.
- a lot (many, many files) of Heroic's java code is incorrectly indented with 2 spaces unfortunately, which means the build fails. Hence commenting this out for now.
- a lot (many, many files) of Heroic's java code is incorrectly separated, hence leaving that big task for another issue/card. Signed-off-by: Peter Kingswell <peterk@spotify.com>
sming
changed the title
sming
changed the title
Signed-off-by: Peter Kingswell <peterk@spotify.com>
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
=========================================
Coverage 54.94% 54.95%
- Complexity 3103 3104 +1
=========================================
Files 739 739
Lines 20143 20143
Branches 1312 1312
=========================================
+ Hits 11067 11069 +2
+ Misses 8608 8607 -1
+ Partials 468 467 -1
Continue to review full report at Codecov.
|
Signed-off-by: Peter Kingswell <peterk@spotify.com>
lmuhlha
approved these changes
Dec 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codestyle: update from 6.x to 8.x #726
Use Case Resolved: start process of tidying up codebase
NOTE: this just updates checkstyle from 6.x to 8.x. The major piece of work remaining is to correct all the offending code.
Design & Implementation Notes
Use Case Resolved: avoidable debate during code review that wastes time
Design & Implementation Notes