Update check for table existence to be case insensitive (#2086)

spotify · Jun 24, 2017 · 8874b93 · 8874b93
1 parent 61ee32e
commit 8874b93
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/luigi/contrib/redshift.py b/luigi/contrib/redshift.py
@@ -332,11 +332,11 @@ def does_table_exist(self, connection):
         if '.' in self.table:
             query = ("select 1 as table_exists "
                      "from information_schema.tables "
-                     "where table_schema = %s and table_name = %s limit 1")
+                     "where table_schema = lower(%s) and table_name = lower(%s) limit 1")
         else:
             query = ("select 1 as table_exists "
                      "from pg_table_def "
-                     "where tablename = %s limit 1")
+                     "where tablename = lower(%s) limit 1")
         cursor = connection.cursor()
         try:
             cursor.execute(query, tuple(self.table.split('.')))

diff --git a/test/contrib/redshift_test.py b/test/contrib/redshift_test.py
@@ -123,7 +123,7 @@ def test_s3_copy_to_table(self, mock_redshift_target, mock_copy):
         # Check the SQL query in `S3CopyToTable.does_table_exist`.
         mock_cursor.execute.assert_called_with("select 1 as table_exists "
                                                "from pg_table_def "
-                                               "where tablename = %s limit 1",
+                                               "where tablename = lower(%s) limit 1",
                                                (task.table,))
 
         return
@@ -188,7 +188,7 @@ def test_s3_copy_to_temp_table(self, mock_redshift_target, mock_copy):
         mock_cursor.execute.assert_any_call(
             "select 1 as table_exists "
             "from pg_table_def "
-            "where tablename = %s limit 1",
+            "where tablename = lower(%s) limit 1",
             (task.table,),
         )
 
@@ -212,8 +212,8 @@ def test_s3_copy_to_table(self, mock_redshift_target, mock_copy):
         mock_cursor.execute.assert_called_with(
             "select 1 as table_exists "
             "from information_schema.tables "
-            "where table_schema = %s and "
-            "table_name = %s limit 1",
+            "where table_schema = lower(%s) and "
+            "table_name = lower(%s) limit 1",
             tuple(task.table.split('.')),
         )