Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade prometheus_client #3161

Closed
nstinus opened this issue May 9, 2022 · 2 comments
Closed

Upgrade prometheus_client #3161

nstinus opened this issue May 9, 2022 · 2 comments

Comments

@nstinus
Copy link
Contributor

nstinus commented May 9, 2022 •
edited
Loading

Currently, yoshi pins the prometheus_client dependency to 0.5.0 which is more than 3yo. Latest is 0.14.
Having such an old version prevents the installation of other libs next to luigi in a conda env.
@lallea
Copy link
Contributor

lallea commented May 9, 2022

Yoshi? I suppose you mean luigi.

I have learnt the hard way that for python, it is preferable to specify ranges of dependency versions. I guess a newer version would also pass the test suite. May I suggest that you send a pull request with a range specification and a newer version in tox.ini? I guess that should be sufficient.

dlstadther pushed a commit that referenced this issue May 12, 2022
@nstinus
Relax prometheus_client version (#3161) (#3163)
62d1672
@dlstadther
Copy link
Collaborator

Closed by #3163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nstinus @lallea @dlstadther