Retries get_work on null response #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this has been happening to me about 4 times a day since recently moving my scheduler to a different server from my workers. |
daveFNbuck
force-pushed
the
recover_from_bad_get_work
branch
from
f693f12
to
72697e3
Compare
|
LGTM but why does the scheduler return a null result? That sounds like the underlying issue |
|
I have no idea how that happens or whether it's a network issue or a scheduler issue. I don't think my logs go back far enough to check. |
|
oops seems like there's a merge conflict here. any chance you can rebase? |
daveFNbuck
force-pushed
the
recover_from_bad_get_work
branch
from
72697e3
to
ab06173
Compare
|
Done. Thanks for all the merges today! |
Sometimes the scheduler gives a null response to get_work, resulting in an error when the worker tries to treat the response as a dict and killing the worker. This change will retry up to 3 times upon receiving a null response, allowing the worker to live and continue working.
daveFNbuck
force-pushed
the
recover_from_bad_get_work
branch
from
ab06173
to
bec17e2
Compare
erikbern
added a commit
that referenced
this pull request
Nov 19, 2015
Retries get_work on null response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the scheduler gives a null response to get_work, resulting in an error
when the worker tries to treat the response as a dict and killing the worker.
This change will retry up to 3 times upon receiving a null response, allowing
the worker to live and continue working.
Note: this has a merge conflict with #1341 because they both modify get_work but it's easily resolved.