Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise an error when no columns are found #1676

Merged
merged 2 commits into from
Jun 3, 2016

Commits on May 4, 2016

  1. raise an error when no columns are found

    The method `create_table` uses the length of the first element of the `columns` property to determine how column names are formatted. Unfortunately this is not exhaustive case coverage. For instance, if a `columns` property is formatted improperly, `create_table` can fail silently, matching neither the first nor the second if clause. In such cases we should alert the user that something has gone awry.
    
    To remedy this, here we raise a `ValueError` when neither if clause is met. This both alerts the user to the cause of the problem and halts the application from making erroneous and incorrect progress. If we prefer to make the `CREATE` query optional, we could instead log an error to stderr, however it seems unlikely that we would ever wish to not create our tables.
    maxcountryman committed May 4, 2016
    Configuration menu
    Copy the full SHA
    cc83847 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2016

  1. fixup! fix indentation

    maxcountryman committed May 18, 2016
    Configuration menu
    Copy the full SHA
    258f757 View commit details
    Browse the repository at this point in the history