fix contrib.docker_runner exit code check #2355 #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonromai
force-pushed
the
romain/fix-build
branch
3 times, most recently
from
feb1dcc
to
67a91e6
Compare
yonromai
changed the title
yonromai
force-pushed
the
romain/fix-build
branch
from
67a91e6
to
318b0e6
Compare
dlstadther
approved these changes
Feb 19, 2018
|
+1 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to
3.0.0,docker-pyused to return the status code as anint- it now returns adict(cf. 2.7.0Container.waitdoc vs 3.0.1Container.waitdoc)The fix is to check if the return type is a dict, to attempt to maintain backward compatibility.