Change task result parameter value to TEXT #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this extensively against PostgreSQL and SQLite and it migrates things correctly if moving from a previous table on PostgreSQL. SQLite doesn't support changing column types without changing the table name and copying the data over so a warning message is logged if the migration can't be run. |
kwilcox
changed the title
Tarrasch
approved these changes
Apr 24, 2018
|
@kwilcox it looks great. I believe that it would work. thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual rebase of #2241 onto master with one additional commit.
Description
Parameter values longer than 256 characters currently fail to be written to the SQL result store. This changes the task value column to TEXT to avoid the issue.
Motivation and Context
Fixes #2240
Fixes #1885
Have you tested this? If so, how?
I've tested this against a PostgreSQL setup, both a new database and existing database, and it works. I have not tested any other dialects (help plz). The existing tests should cover MySQL and SQLite? Marking WIP until I can confirm this works with the required dialects.