ChoiceParameter should raise an error when passed invalid choice #2454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validates
ChoiceParameter
when initializing a task by moving the logic from.parse
to.normalize
. Currently this validation only runs when calling from the command line, when the method.parse
is called. Moving it to.normalize
ensure it always runsMotivation and Context
I was having an issue where I was requiring a task with an invalid ChoiceParameter but no ValueError was raising at task init time.
Have you tested this? If so, how?
Added tests