Optional TOML configs support #2457

orsinium · 2018-07-13T15:25:04Z

Description

Added parser for TOML configs.
TOML config parser can read files from luigi/base.toml and luigi/local.toml. This is useful for effective secrets management via VCS.
You can select config parser via LUIGI_CONFIG_PARSER env var.

Motivation and Context

TOML standardized, modern format which supports data types.
It is useful setup common default options in config files, not in tasks.
Now we can write new config parsers for other formats like YAML without pain. Luigi has been more flexible and extendable.

Have you tested this? If so, how?

I have included unit tests.
I ran my jobs with this code and it works for me.

Pygments doesn't supports TOML by default https://gitlab.com/gitlab-org/gitlab-pygments-rb/commit/d460ba68716937e59498f95fd34709d98990dea3

dlstadther

@orsinium , Thanks for your submission!

I like the idea here (enabling other styles of configuration formats), but I'm not yet sold on why we'd want other formats.

Do other configuration formats allow features that ConfigParser doesn't? If so, what are they and how are they applicable to luigi?

(I anticipated your clarification to my concern above and I've gone ahead and reviewed your code. Those comments and questions are below.)

dlstadther · 2018-07-13T19:10:07Z

doc/configuration.rst

+* ``/etc/luigi/luigi.toml``
+* ``luigi.toml``
+* ``luigi/base.toml``
+* ``luigi/local.toml``


Could you explain why base.toml and local.toml are proposed as valid configuration file names?

Because implicit better than explicit. Now we can use explicit inheritance via luigi.cfg and LUIGI_CONFIG_PATH=luigi_local.cfg. Motivation of inheritance I describe in Pull Request: this is useful for configuring default settings, that can be overridden inlocal config.

You mean that it uses local first and then base. Which makes sense so you can have local changes that don't conflict with the base config.

I'm removing base and local configs. This need be discussed in future for better realization.

dlstadther · 2018-07-13T19:11:09Z

doc/configuration.rst

@@ -23,6 +41,17 @@ The config file is broken into sections, each controlling a different part of th
 [core]
 scheduler_host=luigi-host.mycompany.foo

+Example toml config:
+
+.. code:: python


why is python used here for code syntax highlighting?

Because Pygments doesn't have available lexerfor TOML. This is already contributed in some Pygments versions:

pygments.rb

gitlab-pygments-rb

But Pygments which used for travis checks doesn't have this lexer yet. I choose python as alternative lexer because toml syntax very similar to hybrid of python and ini :)

And a TODO then please. :)

dlstadther · 2018-07-13T19:11:35Z

doc/configuration.rst

+ streaming-jar = "/usr/lib/hadoop-xyz/hadoop-streaming-xyz-123.jar"
+
+ [core]
+ scheduler_host = "luigi-host.mycompany.foo"


are single quotes acceptable too?

Yes, see TOML spec for more details about syntax

Maybe link to the spec in the docs too?

dlstadther · 2018-07-13T19:12:14Z

luigi/configuration/__init__.py

@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+#
+# Copyright 2012-2015 Spotify AB


Shouldn't these dates include 2018. Probably not that important

I just copied Apache license notice from original configuration.py. You can improve it, I don't now how it must be look in right way.

Yea I think this is fine ...

dlstadther · 2018-07-13T19:15:53Z

luigi/configuration/base_parser.py

+ if cls._instance is None:
+ cls._instance = cls(*args, **kwargs)
+ loaded = cls._instance.reload()
+ logging.getLogger('luigi-interface').info('Loaded %r', loaded)


side note: am i correct that neither the client nor the server's logging config names are configurable? I've found that interesting - why statically set to luigi-interface. Perhaps we don't want that changed in general.

I don't change .instance() logic, just moved it from cfg parser to base.

Yeah, I was just raising an unrelated question - a topic for future possible PR (configurable logging names).

Nothing for you to do here.

dlstadther · 2018-07-13T19:16:32Z

luigi/configuration/base_parser.py

+ return cls._instance
+
+ @classmethod
+ def add_config_path(cls, path):


Any reason for changing the order of these classmethods?

What did you mean? I just moved this method from cfg parser to base without any changes.

dlstadther · 2018-07-13T19:17:15Z

luigi/configuration/base_parser.py

+
+class BaseParser:
+ _instance = None
+ _config_paths = []


Shouldn't this be an abstract property that is required to be overwritten?

Yeah, this can be confusable if somebody try to use different parsers in one project. I fix it. Thank you for review :)

dlstadther · 2018-07-13T19:18:51Z

luigi/configuration/toml_parser.py

+# limitations under the License.
+#
+import os
+import os.path


why import both os and os.path? import os.path can be removed

Nearly. import os can be removed, not os.path. Fixed. Thank you.

dlstadther · 2018-07-13T19:22:05Z

luigi/configuration/getter.py

+}
+
+
+def get_config(parser=os.environ.get('LUIGI_CONFIG_PARSER', 'cfg')):


Am i correct that if you want to use a config parser other than cfg, you have to define the LUIGI_CONFIG_PARSER environmental variable?

Yes, you're right. I plan to contribute ability to set up config parser as argument for worker's run. But now Luigi supports config parser chainging only via env var. I write it into documentation.

dlstadther · 2018-07-13T19:22:59Z

setup.py

@@ -39,6 +39,7 @@ def get_static_files(path):
 install_requires = [
 'tornado>=4.0,<5',
 'python-daemon<3.0',
+ 'toml',


No version specification?

Right, I think, we don't need specify library version. This library exposes an API familiar to users of the standard library json, marshal and pickle, and authors will not change it in future.

orsinium · 2018-07-14T07:32:57Z

Yes, TOML, opposite to ini, supports data types like integer, float, boolean, list, dict. Ini supports only strings.

In future, I plan to contribute pyproject.toml support, when tools like pip and setuptools will migrate on it. Also you can read in this article other benefits of migration from ini to toml.

Thank you for good question :)

orsinium · 2018-07-14T09:33:02Z

By the way, thank you for useful library, guys. Luigi is save many hours for our team :)

Tarrasch

Looks like a nice contribution. How long have you used this in prod?

Tarrasch · 2018-07-15T09:48:59Z

doc/configuration.rst


-in increasing order of preference. The order only matters in case of key conflicts (see docs for ConfigParser.read_). These files are meant for both the client and ``luigid``. If you decide to specify your own configuration you should make sure that both the client and ``luigid`` load it properly.
+You can choose right parser via ``LUIGI_CONFIG_PARSER`` environment variable. For example, ``LUIGI_CONFIG_PARSER=toml``.


Can we instead require that the file must end in .toml? It's very little magic for more convenience.

I think about it, but this is very explicit while we have many possible places for configs. What if we have luigi.cfg and luigi.toml? We can't combine it into one config.

I think we can add an improvement down the road to define a hierarchical level of config extensions. I.e. (.cfg, .toml, .yml, <etc.>). I'm fine with requiring an ENV variable for now

Tarrasch · 2018-07-15T09:52:08Z

doc/configuration.rst

+* ``/etc/luigi/luigi.toml``
+* ``luigi.toml``
+* ``luigi/base.toml``
+* ``luigi/local.toml``


You mean that it uses local first and then base. Which makes sense so you can have local changes that don't conflict with the base config.

Tarrasch · 2018-07-15T09:53:53Z

doc/configuration.rst

@@ -23,6 +41,17 @@ The config file is broken into sections, each controlling a different part of th
 [core]
 scheduler_host=luigi-host.mycompany.foo

+Example toml config:
+
+.. code:: python


And a TODO then please. :)

Tarrasch · 2018-07-15T09:54:10Z

doc/configuration.rst

+ streaming-jar = "/usr/lib/hadoop-xyz/hadoop-streaming-xyz-123.jar"
+
+ [core]
+ scheduler_host = "luigi-host.mycompany.foo"


Maybe link to the spec in the docs too?

Tarrasch · 2018-07-15T09:54:23Z

luigi/configuration/__init__.py

@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+#
+# Copyright 2012-2015 Spotify AB


Yea I think this is fine ...

Tarrasch · 2018-07-15T09:54:52Z

luigi/configuration/base_parser.py

+import logging
+
+
+class BaseParser:


inherit from object?

No-no-no, don't do it! In Python2 cfg parser fails if BaseParser inherit from object. This is strange, yes. I will add comment for it

Tarrasch · 2018-07-15T09:55:41Z

luigi/configuration/cfg_parser.py

@@ -38,8 +37,10 @@
 except ImportError:
 from configparser import ConfigParser, NoOptionError, NoSectionError

+from .base_parser import BaseParser


I recall relative imports are discouraged, no?

Why? We already have from .tools import range in project, and it's works. Relative imports little faster and better recognized some tools like isort.

Tarrasch · 2018-07-15T09:58:04Z

setup.py

@@ -39,6 +39,7 @@ def get_static_files(path):
 install_requires = [
 'tornado>=4.0,<5',
 'python-daemon<3.0',
+ 'toml',


Can this be excluded? Eventually we want to populate this with dependencies needed but it's important that you can run luigi without toml installed.

Tarrasch · 2018-07-15T09:59:35Z

luigi/configuration/getter.py

@@ -0,0 +1,34 @@
+# -*- coding: utf-8 -*-


Is there a better name than getter.py?

orsinium · 2018-07-15T10:31:21Z

Good question, thank you :) I used it only one day on the dev. I make this feature for our team and send this Pull Request immediately. I can give here feedback after 1-2 weeks of active usage. I think, this is a good idea, thank you.

orsinium · 2018-07-16T14:31:46Z

Improved some things:

Dropped luigi/base.toml and luigi/local.toml paths. Inheritance must be discussed in future.
Added function for adding config in paths list of current active config parser.
Now TOML-parser's requirements optional for luigi and can be installed via extras: pip install luigi[toml]
For TOML parser we can get sections and options as attributes: config['mongo']['port'].
FIX catching config option getting in whole project: cfg parser raises NoSectionError, but TOML parser raises KeyError. Raise from new parsers exceptions from configparser -- bad idea.

Also you can run example project as proof-of-concept. For example, I am getting config['mongo']['port'] and this is returns int, not str. Soooo beautiful :)

orsinium · 2018-07-16T14:32:55Z

codecov shows strange things. Don't trust it.

dlstadther · 2018-07-22T20:11:01Z

Hey @orsinium. Thanks for providing a new summary of updates. I'll try to take another look this work week! Sorry for the delay! (and yeah, don't worry so much about codecov)

orsinium · 2018-07-23T07:28:21Z

I'm fine. Codecov good and fair again :)

orsinium · 2018-07-23T07:34:48Z

Today I'll try to run our new pipeline with this improvements. I'll give you feedback soon.

dlstadther

Let us know the results of your pipeline execution as it relates to this PR :)

dlstadther · 2018-07-23T12:30:55Z

doc/configuration.rst

+* ``luigi.toml``
+* ``LUIGI_CONFIG_PATH`` environment variable
+
+Both config lists reversordered by priotity (from low to high). The order only matters in case of key conflicts (see docs for ConfigParser.read_). These files are meant for both the client and ``luigid``. If you decide to specify your own configuration you should make sure that both the client and ``luigid`` load it properly.


reversordered is not a word. Perhaps we reword something to the effect of the below:

Both config lists increase in priority (from low to high).

dlstadther · 2018-07-23T12:33:42Z

luigi/configuration/base_parser.py

+
+# IMPORTANT: don't inherit from `object`!
+# ConfigParser have some troubles in this case.
+class BaseParser:


The issue is explained better on SO

dlstadther · 2018-07-23T12:35:11Z

luigi/configuration/base_parser.py

+ if cls._instance is None:
+ cls._instance = cls(*args, **kwargs)
+ loaded = cls._instance.reload()
+ logging.getLogger('luigi-interface').info('Loaded %r', loaded)


Yeah, I was just raising an unrelated question - a topic for future possible PR (configurable logging names).

Nothing for you to do here.

orsinium · 2018-07-25T16:07:35Z

All is fine, our pipeline works right with new configs. I'm planning to commit dlstadther's improvements tomorrow.

Future improvements for other pull requests:

1. Local configs

I want to have file for local settings for storing some config in env

2. Configure logging via main config

Config example:

[logging]
version = 1
disable_existing_loggers = true

[logging.formatters.simple]
format = "{levelname:8} {asctime} {module}:{lineno} {message}"
style = "{"
datefmt = "%Y-%m-%d %H:%M:%S"

[logging.handlers.console]
level = "DEBUG"
class = "logging.StreamHandler"
formatter = "simple"

[logging.loggers.parser]
handlers = ["console"]
level = "DEBUG"
disabled = false
propagate = false

How we use it in our projects:

import os.path
import logging
from logging.config import dictConfig
import toml

path = os.path.dirname(os.path.abspath(__file__))
CONFIG = toml.load(os.path.join(path, 'config.toml'))

dictConfig(CONFIG['logging'])
logger = logging.getLogger('parser')

orsinium · 2018-07-26T14:21:21Z

Added all actual @dlstadther 's improvements and merged spotify/master

orsinium · 2018-07-26T14:23:44Z

@ulzha, sorry for mentioning. This is from my branch actualization

dlstadther

Just a couple comments and clarifying questions

dlstadther · 2018-07-26T14:51:46Z

doc/configuration.rst


-in increasing order of preference. The order only matters in case of key conflicts (see docs for ConfigParser.read_). These files are meant for both the client and ``luigid``. If you decide to specify your own configuration you should make sure that both the client and ``luigid`` load it properly.
+You can choose right parser via ``LUIGI_CONFIG_PARSER`` environment variable. For example, ``LUIGI_CONFIG_PARSER=toml``.


I think we can add an improvement down the road to define a hierarchical level of config extensions. I.e. (.cfg, .toml, .yml, <etc.>). I'm fine with requiring an ENV variable for now

dlstadther · 2018-07-26T14:58:20Z

luigi/contrib/s3.py

@@ -486,7 +486,7 @@ def _get_s3_config(self, key=None):
 defaults = dict(configuration.get_config().defaults())
 try:
 config = dict(configuration.get_config().items('s3'))
- except NoSectionError:
+ except (NoSectionError, KeyError):


Am i correct to assume that ConfigParser returns the NoSectionError and toml returns the KeyError when a config section heading is missing?

Yes. I think, this is incorrect raise from toml parser any exceptions from ConfigParser. Maybe, we can make custom common exception:

class SectionError(NoSectionError, KeyError): pass

I'm fine with it as it is currently written; I was just verifying that they raised different errors for the same problem.

dlstadther · 2018-07-26T15:01:05Z

setup.py

@@ -75,6 +76,9 @@ def get_static_files(path):
 ]
 },
 install_requires=install_requires,
+ extras_require={
+ 'toml': ['toml'],


What are your thoughts on limiting this to the current milestone version? i.e. 'toml<1.0' (since the current is 0.9.4) I just don't want version 1.0.0 to break this. I'd rather tread with caution, even with an optional configurable feature.

Python toml package version related to toml spec version. TOML spec v1.0 will be backward compatible. Some quotes:

1.0.0 will be the first version to support TOML 1.0.0. TOML still has yet to hit TOML 1.0.0 so its release is postponed indefinitely.

As of version 0.5.0, TOML should be considered extremely stable. The goal is for version 1.0.0 to be backwards compatible (as much as humanly possible) with version 0.5.0. All implementations are strongly encouraged to become 0.5.0 compatible so that the transition to 1.0.0 will be simple when that happens.

In that case, why don't we put 'toml<2.0'?

Ok. This don't break anything. This fix added. Thank you for review :)

dlstadther · 2018-07-26T15:01:31Z

tox.ini

@@ -35,6 +35,7 @@ deps=
 hypothesis[datetime]
 selenium==3.0.2
 pymongo==3.4.0
+ toml


If we agree to a version requirement in setup.py, it'll need to be reflected here.

orsinium · 2018-07-27T12:55:01Z

I think, this PR is ready to merge. What do you think? :)

dlstadther

I'm good with this now

Tarrasch · 2018-07-28T18:56:46Z

Good then! Let's see if this gets well used by othres. 🙌

orsinium · 2018-07-28T19:05:43Z

Thank you! We've done great work :)

See the added docs for usage.

* upstream-master: (82 commits) S3 client refactor (spotify#2482) Rename to rpc_log_retries, and make it apply to all the logging involved Factor log_exceptions into a configuration parameter Fix attribute forwarding for tasks with dynamic dependencies (spotify#2478) Add a visiblity level for luigi.Parameters (spotify#2278) Add support for multiple requires and inherits arguments (spotify#2475) Add metadata columns to the RDBMS contrib (spotify#2440) Fix race condition in luigi.lock.acquire_for (spotify#2357) (spotify#2477) tests: Use RunOnceTask where possible (spotify#2476) Optional TOML configs support (spotify#2457) Added default port behaviour for Redshift (spotify#2474) Add codeowners file with default and specific example (spotify#2465) Add Data Revenue to the `blogged` list (spotify#2472) Fix Scheduler.add_task to overwrite accepts_messages attribute. (spotify#2469) Use task_id comparison in Task.__eq__. (spotify#2462) Add stale config Move github templates to .github dir Fix transfer config import (spotify#2458) Additions to provide support for the Load Sharing Facility (LSF) job scheduler (spotify#2373) Version 2.7.6 ...

* upstream-master: S3 client refactor (spotify#2482) Rename to rpc_log_retries, and make it apply to all the logging involved Factor log_exceptions into a configuration parameter Fix attribute forwarding for tasks with dynamic dependencies (spotify#2478) Add a visiblity level for luigi.Parameters (spotify#2278) Add support for multiple requires and inherits arguments (spotify#2475) Add metadata columns to the RDBMS contrib (spotify#2440) Fix race condition in luigi.lock.acquire_for (spotify#2357) (spotify#2477) tests: Use RunOnceTask where possible (spotify#2476) Optional TOML configs support (spotify#2457) Added default port behaviour for Redshift (spotify#2474) Add codeowners file with default and specific example (spotify#2465) Add Data Revenue to the `blogged` list (spotify#2472)

* upstream-master: Remove long-deprecated scheduler config variable alternatives (spotify#2491) Bump tornado milestone version (spotify#2490) Update moto to 1.x milestone version (spotify#2471) Use passed password when create a redis connection (spotify#2489) S3 client refactor (spotify#2482) Rename to rpc_log_retries, and make it apply to all the logging involved Factor log_exceptions into a configuration parameter Fix attribute forwarding for tasks with dynamic dependencies (spotify#2478) Add a visiblity level for luigi.Parameters (spotify#2278) Add support for multiple requires and inherits arguments (spotify#2475) Add metadata columns to the RDBMS contrib (spotify#2440) Fix race condition in luigi.lock.acquire_for (spotify#2357) (spotify#2477) tests: Use RunOnceTask where possible (spotify#2476) Optional TOML configs support (spotify#2457) Added default port behaviour for Redshift (spotify#2474) Add codeowners file with default and specific example (spotify#2465) Add Data Revenue to the `blogged` list (spotify#2472) Fix Scheduler.add_task to overwrite accepts_messages attribute. (spotify#2469) Use task_id comparison in Task.__eq__. (spotify#2462)

adamist521 · 2018-08-25T00:41:10Z

luigi/configuration/toml_parser.py

+try:
+ import toml
+except ImportError:
+ toml = False


@orsinium
This will end up following error if you have toml library not installed...
Works great after toml installation!

File "/Users/*****/.pyenv/versions/miniconda-latest/envs/ddhr-rjb/lib/python3.6/site-packages/luigi/configuration/toml_parser.py", line 53, in read self.data = self._update_data(self.data, toml.load(path)) AttributeError: 'bool' object has no attribute 'load'

Oh noes, @orsinium can you fix this asap?

orsinium · 2018-08-25T18:05:35Z

@adamist521, please, can you provide full traceback?

orsinium · 2018-08-25T19:30:44Z

@Tarrasch, don't panic. This is unusual usage or something like this, because get_config function checks reader's enabled option. Also this error possible when you install Luigi without toml support, but want to use toml parser.

Hmmmm... I need to add info about toml support in installation section :)

honnix · 2018-09-06T08:07:08Z

This PR effectively fails from luigi.configuration import NoSectionError. Was this intended?

orsinium · 2018-09-06T14:00:01Z

Yes. Please, import NoSectionError from configparser from stdlib:

from configparser import NoSectionError```

orsinium added 11 commits July 13, 2018 13:45

mv cfg parser

d00f793

split cfg parser and config getter

783ddeb

+TOML config parser

fd4e30f

improve config getter

d712827

+Apache License in new files

bcb59e0

TOML config parser tests

0242248

override configs by keys

debea65

Documentation for TOML config parser

ddfb5be

Merge branch 'config'

d0caa72

FIX lexer error

3261393

Pygments doesn't supports TOML by default https://gitlab.com/gitlab-org/gitlab-pygments-rb/commit/d460ba68716937e59498f95fd34709d98990dea3

FIX lexer error

edf41c8

Pygments doesn't supports TOML by default https://gitlab.com/gitlab-org/gitlab-pygments-rb/commit/d460ba68716937e59498f95fd34709d98990dea3

dlstadther requested changes Jul 13, 2018

View reviewed changes

orsinium added 2 commits July 14, 2018 11:54

FIX: no shared instance between different config parsers

1d0d110

rm unused os import

6142834

Tarrasch reviewed Jul 15, 2018

View reviewed changes

orsinium added 10 commits July 16, 2018 11:30

Merge remote-tracking branch 'origin/config'

d86414a

+getitem for config

b88376a

improve config paths

f4c128a

add config function

ba20f7b

sort imports

22b7368

make additional parsers optional

95fa46b

improve add_config_path for default parser

913fe19

FIX package installation

ae050b0

FIX TOML parser raises KeyError, not NoSectionError

284cc26

Merge branch 'improve-config' into config

0d6943a

dlstadther reviewed Jul 23, 2018

View reviewed changes

orsinium added 2 commits July 26, 2018 17:16

Merge remote-tracking branch 'spotify/master' into config

1c9129b

dlstadther's improvements

3843761

orsinium requested a review from ulzha as a code owner July 26, 2018 14:20

dlstadther reviewed Jul 26, 2018

View reviewed changes

toml version pinning

09ace16

dlstadther approved these changes Jul 27, 2018

View reviewed changes

Tarrasch merged commit 7d2c557 into spotify:master Jul 28, 2018

thisiscab pushed a commit to glossier/luigi that referenced this pull request Aug 3, 2018

Optional TOML configs support (spotify#2457)

9f53695

See the added docs for usage.

thisiscab pushed a commit to glossier/luigi that referenced this pull request Aug 8, 2018

Optional TOML configs support (spotify#2457)

41c431f

See the added docs for usage.

adamist521 reviewed Aug 25, 2018

View reviewed changes

orsinium mentioned this pull request Aug 27, 2018

Fix exception when toml lib is not installed #2506

Merged

honnix mentioned this pull request Sep 6, 2018

Expose NoSectionError at package level #2517

Closed

orsinium mentioned this pull request Oct 12, 2020

YAML support for the file backend muesli/beehive#339

Merged

		}


		def get_config(parser=os.environ.get('LUIGI_CONFIG_PARSER', 'cfg')):


		in increasing order of preference. The order only matters in case of key conflicts (see docs for ConfigParser.read_). These files are meant for both the client and ``luigid``. If you decide to specify your own configuration you should make sure that both the client and ``luigid`` load it properly.
		You can choose right parser via ``LUIGI_CONFIG_PARSER`` environment variable. For example, ``LUIGI_CONFIG_PARSER=toml``.

Optional TOML configs support #2457

Optional TOML configs support #2457

Conversation

orsinium commented Jul 13, 2018

Description

Motivation and Context

Have you tested this? If so, how?

dlstadther left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

orsinium commented Jul 14, 2018

orsinium commented Jul 14, 2018

Tarrasch left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

orsinium commented Jul 15, 2018

orsinium commented Jul 16, 2018

orsinium commented Jul 16, 2018

dlstadther commented Jul 22, 2018

orsinium commented Jul 23, 2018

orsinium commented Jul 23, 2018

dlstadther left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

orsinium commented Jul 25, 2018 • edited Loading

1. Local configs

2. Configure logging via main config

orsinium commented Jul 26, 2018

orsinium commented Jul 26, 2018

dlstadther left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

orsinium Jul 27, 2018 • edited Loading

Choose a reason for hiding this comment

orsinium commented Jul 25, 2018 •

edited

Loading

orsinium Jul 27, 2018 •

edited

Loading

adamist521 Aug 25, 2018 •

edited

Loading