Ensure ignored tests are picked up by tox #2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tox has not been running range_test.py due to the file being executable. This commit sets the file permissions to read/write only and remediates the problems that arose when the tests ran again: * Some tests for RangeMonthly were not accurately capturing the correct logic * Some tests were not compatible with Python 3 in some map operations * RangeByMinutesBase performed arithmetics that yield different results on Python 2 and 3, this was changed to be more resilient on both. May have impact on those relying on the erroneous behavior right now.
Tox has not been running contrib/sge_test.py due to the file being executable. This commit sets the file permissions to read/write only and remediates the problems that arose when the tests ran again: * pickle.dump() behaves differently in Python 2 and 3, ensure that it works for both * Get rid of warnings about unclosed files, handling file lifecycles properly * Minor docstring syntax
|
Seems like the codecov/patch step fails because I changed some file handling operations. I noticed the way files were handled wasn't safe (they were opened but not closed) so I added functionality for closing them while I was making the tests work in the same code parts. Now codecov is complaining I didn't add a test for it. Is this vital to fix? Or is the problem due to something else? |
dlstadther
approved these changes
Aug 12, 2019
|
Thank you @dlstadther. How do I get it merged? |
GoodDok
pushed a commit
to GoodDok/luigi
that referenced
this pull request
Aug 23, 2019
* Enable erroneously skipped range tests Tox has not been running range_test.py due to the file being executable. This commit sets the file permissions to read/write only and remediates the problems that arose when the tests ran again: * Some tests for RangeMonthly were not accurately capturing the correct logic * Some tests were not compatible with Python 3 in some map operations * RangeByMinutesBase performed arithmetics that yield different results on Python 2 and 3, this was changed to be more resilient on both. May have impact on those relying on the erroneous behavior right now. * Enable erroneously skipped SGE tests Tox has not been running contrib/sge_test.py due to the file being executable. This commit sets the file permissions to read/write only and remediates the problems that arose when the tests ran again: * pickle.dump() behaves differently in Python 2 and 3, ensure that it works for both * Get rid of warnings about unclosed files, handling file lifecycles properly * Minor docstring syntax
GoodDok
pushed a commit
to GoodDok/luigi
that referenced
this pull request
Aug 23, 2019
* Enable erroneously skipped range tests Tox has not been running range_test.py due to the file being executable. This commit sets the file permissions to read/write only and remediates the problems that arose when the tests ran again: * Some tests for RangeMonthly were not accurately capturing the correct logic * Some tests were not compatible with Python 3 in some map operations * RangeByMinutesBase performed arithmetics that yield different results on Python 2 and 3, this was changed to be more resilient on both. May have impact on those relying on the erroneous behavior right now. * Enable erroneously skipped SGE tests Tox has not been running contrib/sge_test.py due to the file being executable. This commit sets the file permissions to read/write only and remediates the problems that arose when the tests ran again: * pickle.dump() behaves differently in Python 2 and 3, ensure that it works for both * Get rid of warnings about unclosed files, handling file lifecycles properly * Minor docstring syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2757, see full description of motivation there.
The change modifies file permissions on
range_test.pyandsge_test.pyfrom 755 to 644 so that they are actually picked up by tox. This revealed a bunch of failing tests that I also fixed. In some cases because the tests were wrong, in other cases because of actual problems in the luigi functionality. The commit messages contain detailed explanations of the changes.The change has been tested by running the concerned files manually with
python -m unittest <module>, and also by running the full tox test suite on my machine, verifying that 1) the tests are picked up, 2) they go through, 3) no other tests are impacted.Would like @lallea to review the parts concerning MonthInstantiationTest.