PySparkTask: handle special characters in name (#2778) #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrk-its
requested review from
dlstadther,
honnix and
Tarrasch
as code owners
GoodDok
approved these changes
Sep 10, 2019
luigi/contrib/spark.py
Outdated
| @@ -298,8 +299,9 @@ def app_command(self): | |||
| return [self.app, pickle_loc] + self.app_options() | |||
|
|
|||
| def run(self): | |||
| self.run_path = tempfile.mkdtemp(prefix=self.name) | |||
| self.run_pickle = os.path.join(self.run_path, '.'.join([self.name.replace(' ', '_'), 'pickle'])) | |||
| name = re.sub(r'[^\w]', '_', self.name) | |||
There was a problem hiding this comment.
I'd rename variable name to something like run_path_prefix (maybe some better option) due to two reasons:
- it is actually a path, not a name anymore
- we must be having a hard time dealing with
nameandself.namein the same place
There was a problem hiding this comment.
Good point! Renamed.
|
@Tarrasch @dlstadther could you take a look? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2778
Description
It cleans name property before it is used to derive run_path and run_pickle properties.
Motivation and Context
If name property contains some special characters PySparkTask fails: #2778
Have you tested this? If so, how?
Unit test is included