Added optional argument 'aws_session_token' to S3Client #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bonsanto
force-pushed
the
feature/s3-client-aws-session-provided
branch
from
2e21e02 to
f463631
Compare
dlstadther
reviewed
Oct 6, 2019
|
@dlstadther I'm not sure how to test this feature nevertheless I tried my best adding some tests. |
Bonsanto
force-pushed
the
feature/s3-client-aws-session-provided
branch
2 times, most recently
from
1b26706 to
73f11cd
Compare
Bonsanto
force-pushed
the
feature/s3-client-aws-session-provided
branch
from
73f11cd to
60a5420
Compare
dlstadther
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added optional named argument 'aws_session_token' to luigi.contrib.s3.S3Client class. If this argument is provided then during the
s3method usage it will be used.Motivation and Context
aws_access_key_id,aws_secret_access_keyand some times they also provide you with theaws_session_tokenwhich is mandatory.Have you tested this? If so, how?
I ran many of my jobs locally and it works perfectly.