-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[luigi.contrib.external_program.ExternalProgramTask] logs_output_pattern_to_url provided #2822
Conversation
@honnix @Tarrasch @dlstadther could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any functional change here. Please explain.
LGTM now. |
@honnix |
@drowoseque Could you please take a look why this broke master CI? Thanks. |
I see similar failures in https://travis-ci.org/spotify/luigi/jobs/618083277 but in next build this test was okay https://travis-ci.org/spotify/luigi/builds/619552243
|
@honnix could you please rerun ci ? |
Description
Method
logs_output_pattern_to_url
added toExternalProgramTask
Motivation and Context
Sometimes our external tasks do not contain url in output logs but one easily can be restored from output
For example if we run Tez Task which outputs YARN application id only
we can restore tracking url by appending a resource manager address + endpoint
That could be done by using
logs_output_pattern_to_url
Have you tested this? If so, how?
I've provided unit tests for that