[luigi.contrib.hive] HiveTableTarget inherits HivePartitionTarget #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drowoseque
requested review from
dlstadther,
honnix and
Tarrasch
as code owners
drowoseque
commented
Dec 17, 2019
| @@ -469,34 +469,6 @@ def run_job(self, job, tracking_url_callback=None): | |||
| return luigi.contrib.hadoop.run_and_track_hadoop_job(arglist, job.set_tracking_url) | |||
|
|
|||
|
|
|||
| class HiveTableTarget(luigi.Target): | |||
There was a problem hiding this comment.
I moved this class declaration down to make new parent visible to it
drowoseque
force-pushed
the
hive-table-iherit-from-partition
branch
from
afffb5c to
702a4e7
Compare
|
@honnix |
dlstadther
approved these changes
Dec 30, 2019
dlstadther
approved these changes
Dec 30, 2019
|
@drowoseque Sorry for being late. I saw this PR has been approved. Anything else you need from me apart from merging it? |
@honnix |
|
Yeah one is usually enough. I will take a look just to get informed and then merge it. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
luigi.contrib.hive.HiveTableTargetinheritsHivePartitionTargetMotivation and Context
HiveTableTargetis a particular case ofHivePartitionTargetwith no partitionHiveTableTargetare copy-pasted fromHivePartitionTargetHave you tested this? If so, how?
Unit-tests are updated