Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve speed of get_task_family() #3129

Merged
merged 2 commits into from
Mar 12, 2022
Merged

Improve speed of get_task_family() #3129

merged 2 commits into from
Mar 12, 2022

Conversation

nehaljwani
Copy link
Contributor

@nehaljwani nehaljwani commented Dec 7, 2021 •
edited
Loading

  • Use f-string instead of str.format()
  • Save duplicate call to get_task_namespace()

@nehaljwani nehaljwani requested review from dlstadther and a team as code owners December 7, 2021 21:18
@nehaljwani nehaljwani force-pushed the speed_up_get_task_family branch 2 times, most recently from 7916290 to 430bd58 Compare December 7, 2021 21:25
@nehaljwani
Improve speed of get_task_family()
03f3c7c 
* Use f-string instead of str.format()
* Save duplicate call to get_task_namespace()
@nehaljwani nehaljwani force-pushed the speed_up_get_task_family branch from 430bd58 to 03f3c7c Compare December 7, 2021 21:33
@dlstadther dlstadther merged commit 07f4d7d into spotify:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlstadther dlstadther dlstadther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nehaljwani @dlstadther